New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally include liquibase-scripting.jar in tarball DAT-16671 #5850
base: master
Are you sure you want to change the base?
Conversation
DAT-16671
DAT-16671
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
DAT-16671
This reverts commit a38b324.
DAT-16671
DAT-16671
DAT-16671
@@ -27,11 +27,12 @@ | |||
<db2.version>11.5.9.0</db2.version> | |||
<firebird.version>5.0.4.java8</firebird.version> | |||
<liquibase-pro.version>master-SNAPSHOT</liquibase-pro.version> | |||
<liquibase-scripting.version>0-SNAPSHOT</liquibase-scripting.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be master-SNAPSHOT too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing to me, too. The artifact that is being produced right now is 0-SNAPSHOT
. I think that once devops is finished with their build work it should be master-SNAPSHOT
.
liquibase-dist/pom.xml
Outdated
<id>liquibase-scripting</id> | ||
<activation> | ||
<property> | ||
<name>liquibase.scripting</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the indentation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
DAT-16671
Impact
Description
Things to be aware of
Things to worry about
Additional Context