feat: improve snapshot generation for NOSQL databses #5775
+81
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbiville here we go again! |
filipelautert
requested a deployment
to
internal
GitHub Actions
Abandoned
filipelautert
requested a deployment
to
internal
GitHub Actions
Abandoned
Comment on lines
+62
to
+86
| boolean firstRoundDone = false; | ||
| SnapshotGenerator lastGenerator = null; | ||
| T lastObject = example; | ||
| while (snapshotGenerators.hasNext()) { | ||
| SnapshotGenerator generator = snapshotGenerators.next(); | ||
| if (replacedGenerators.contains(generator.getClass())) { | ||
| continue; | ||
| } | ||
| T object = generator.snapshot(lastObject, snapshot, this); | ||
| if ((object != null) && (object.getSnapshotId() == null)) { | ||
| object.setSnapshotId(snapshotIdService.generateId()); | ||
| } | ||
| // only first generator in the chain is allowed to create new instances - subsequent ones are not | ||
| if (firstRoundDone && object != lastObject) { | ||
| throw new DatabaseException(String.format("Snapshot generator %s has returned a different reference from the previous generator %s.\n" + | ||
| "\tSnapshot object was: %s, it is now: %s.\n" + | ||
| "\tConsider declaring %1$s as being replaced by one the generator in the chain via liquibase.snapshot.SnapshotGenerator#replaces.", | ||
| generator.getClass().getName(), | ||
| lastGenerator.getClass().getName(), | ||
| identity(lastObject), | ||
| identity(object))); | ||
| } | ||
| lastObject = object; | ||
| lastGenerator = generator; | ||
| firstRoundDone = true; |
There was a problem hiding this comment.
This code should be moved to a method that has extensive javadoc on it. It's not obvious what this code is doing currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back what had to be rolledback from PR #5619 to be tested again and fix what is required.
This one may be useful too: https://github.com/liquibase/liquibase-pro/pull/1650