Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CommandOverrideProcessor to validate CommandOverride usage at compile time #5735

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Mar 26, 2024

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds new annotation processor to detect invalid usage of the @CommandOverride annotation.
TODO:

  • Do not print multiple messages, this means the annotation processor is running more than once
  • Re-use code, this is currently duplicating the validation found in CommandFactory.
  • Validate that the new service file is actually needed
  • Get this to build in the pipeline

Things to be aware of

This will (intentionally) break builds.

Things to worry about

This can impact lombok. I don't think it does in its current form, but it can.

Additional Context

… validate at compile time whether there are multiple command overrides present. Still work to be done, it duplicates messages when an invalid build is detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant