-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL execution issue with endDelimiter '/' and splitStatements #5704
base: master
Are you sure you want to change the base?
Conversation
@MalloD12 I added 2 tests, and test ":moreSlashEndDelimiterTest" broke Oracle build. Would it be a valid test case? |
@filipelautert I think that is not a valid case, because after a |
I'm wondering now, whether we should tag this to be documented. @filipelautert do you know if we have things like this in confluence? Before we move ahead with this let me double-check it with Mario. |
liquibase-integration-tests/src/test/resources/changelogs/oracle/complete/root.changelog.xml
Outdated
Show resolved
Hide resolved
@AMBERMW13 @adrian-velonis1 Guys, we have been discussing on Thursday with Mario about documenting these changes as a helpful tip. What we want to document is the technical decision that was made some time ago by Nathan, but which we lightly modified to avoid having issues when using Example 1:
Example 2:
Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rberezen this PR is specific to Oracle sqls.
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
Impact
Description
Fixes #5359
Things to be aware of
Things to worry about
Additional Context