Performance Improvement: optimized DatabaseChangeLog.normalizePath() #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvoxland
changed the title
|
The validation errors appear to be caused by a separate change that was already in master. #3881 |
…rmance # Conflicts: # liquibase-core/src/main/java/liquibase/changelog/DatabaseChangeLog.java
filipelautert
approved these changes
Mar 13, 2023
suryaaki2
approved these changes
Mar 17, 2023
XDelphiGrl
approved these changes
Mar 17, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
PR #3063 improved performance of
DatabaseChangeLog.normalizePath()by no longer re-compiling regular expressions, but it is a method that is called often and with a large changelog it still appears to be a bottleneck.This PR replaces the regular expressions with more efficient "replace" calls and/or adds a "if it might be a problem" gate around the regexp call.
From testing, it removed about half the time spent based on profiling data from #3816
Fixes partially #3816
Things to be aware of
It may be possible to reduce the number of calls to this function in the first place as well. As part of the review process, it is probably worth looking to see if we keep re-calling normalizePath for the same paths over and over or not.
In testing this, the customer reported that it caused some validation errors (see #3816). I'm not sure how it could off hand, since it's just in the normalizePath, it's possibly causing some changesets to be identical now? So needs a bit more unit testing
Things to worry about
Not much, there are existing tests around the normalizePath() which would fail as I pulled out each regexp before replacing it with a comparable replace() call
Additional Context