Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opencsv-upgrade] Updates opencsv to 5.7.1 #3419

Merged
merged 3 commits into from Oct 31, 2022
Merged

[opencsv-upgrade] Updates opencsv to 5.7.1 #3419

merged 3 commits into from Oct 31, 2022

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Oct 27, 2022 •
edited

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Upgrades opencsv dependency and removes commons text exclusions.

Things to be aware of

N/A

Things to worry about

N/A

Additional Context

@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited

Unit Test Results

  4 668 files    4 668 suites   38m 51s ⏱️
  4 624 tests   4 395 ✔️    229 💤 0 ❌
54 696 runs  49 628 ✔️ 5 068 💤 0 ❌

Results for commit 7c9cb9f.

♻️ This comment has been updated with latest results.

XDelphiGrl
XDelphiGrl approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updates OpenCSV dependency to 5.7.1; this addresses a known vulnerability in earlier OpenCSV versions.

  • No Maven Central reported CVEs.
  • No additional testing required.

APPROVED

Maven Central opencsv 5.7.1

@abrackx abrackx marked this pull request as ready for review October 27, 2022 17:07
@crenan
Copy link
Contributor

crenan commented Oct 27, 2022

About the updated opencsv, is there a way to define a locale to run the tests? I have a problem when I run the "invalid csv" test in the CSVReaderTest.groovy file because the message of the returned exception depends on the O.S language.

nvoxland
nvoxland approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking out the temporary exclusions/overrides

@abrackx abrackx merged commit 96c10dd into master Oct 31, 2022
@abrackx abrackx deleted the opencsv-upgrade branch October 31, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@XDelphiGrl XDelphiGrl XDelphiGrl approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abrackx @crenan @nvoxland @XDelphiGrl @suryaaki2