Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade snakeyaml maven reference from 1.32 to 1.33 #3359

Merged
merged 1 commit into from Oct 18, 2022
Merged

Upgrade snakeyaml maven reference from 1.32 to 1.33 #3359

merged 1 commit into from Oct 18, 2022

Conversation

nvoxland
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The CLI and overall project uses snakeyaml 1.33 but there is a separate pom.xml used for what we publish which still uses 1.32.

This upgrades that dependency to macch.

Things to be aware of

  • Impacts people using liquibase as a maven dependency

Things to worry about

  • Nothing

@nvoxland nvoxland added dependencies Pull requests that update a dependency file autocandidate labels Oct 11, 2022
@nvoxland nvoxland mentioned this pull request Oct 11, 2022
Merged
@github-actions
Copy link

Unit Test Results

  4 668 files  ±0    4 668 suites  ±0   32m 59s ⏱️ + 1m 58s
  4 627 tests ±0    4 401 ✔️ ±0     226 💤 ±0  0 ❌ ±0 
54 528 runs  ±0  49 465 ✔️ ±0  5 063 💤 ±0  0 ❌ ±0 

Results for commit 28c17b3. ± Comparison against base commit c9ceb05.

XDelphiGrl
XDelphiGrl approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updates the snkyaml dependency to latest.

  • No Maven Central reported CVEs.
  • No additional testing required.

APPROVED

Maven Central snakeyaml 1.33

@nvoxland nvoxland merged commit db889d9 into master Oct 18, 2022
@nvoxland nvoxland added this to the 1NEXT milestone Oct 18, 2022
@filipelautert filipelautert deleted the update-snakeyaml branch April 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XDelphiGrl XDelphiGrl XDelphiGrl approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees
No one assigned
Labels
autocandidate dependencies Pull requests that update a dependency file
Projects
Liquibase Open Source
Archived in project
Milestone
v4.17.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nvoxland @XDelphiGrl @suryaaki2