Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use liquibase StringUtil not lang3.StringUtils #3338

Merged
merged 1 commit into from Oct 18, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Oct 4, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

We should be using our StringUtil class, not commons.lang3 versions which are not always available.

Things to be aware of

  • Does not change functionality, just changes the method called

Things to worry about

  • Nothing

@nvoxland nvoxland self-assigned this Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results

  4 668 files  ±0    4 668 suites  ±0   36m 12s ⏱️ +6s
  4 627 tests ±0    4 401 ✔️ ±0     226 💤 ±0  0 ±0 
54 528 runs  ±0  49 465 ✔️ ±0  5 063 💤 ±0  0 ±0 

Results for commit c4bad39. ± Comparison against base commit 59ca536.

@nvoxland nvoxland removed their assignment Oct 6, 2022
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix removes use of the org.apache.commons.lang3.StringUtils.isNotBlank() in favor of liquibase.util.StringUtil.isNotEmpty(). This ensures the Liquibase StringUtil class is used consistently in the DatabaseUtils.java class.

  • No additional testing required.

APPROVED

@nvoxland nvoxland merged commit 04c915b into master Oct 18, 2022
@nvoxland nvoxland deleted the fix-stringutil-reference branch October 18, 2022 19:52
@nvoxland nvoxland added this to the 1NEXT milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants