New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logic to validate dbms set at changeset and stored procedure levels #3291
Conversation
… with exclamation sign. Plus test data update.
079d49f
to
975ef86
Compare
Code review and test results: Things to be aware of:
Things to worry about:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix allows Liquibase to validate that the DBMS values provided at the changeset level contain valid database platform shortnames. If a changeset has an unrecognized value in the DBMS attribute, by default, Liquibase will throw a validation error. The DBMS attribute can have one or many comma-separated database shortnames.
- New tests added for one and many DBMS values.
- New test added for createProcedure with DBMS values.
- New test added for DBMS keywords "all" and "none."
- No additional testing required.
APPROVED
Impact
Description
Implement
validateDefinitions()
methods to validate single or a list of dbms attribute values set for a given changeset or store procedure.Fixes #1795
Things to be aware of
Things to worry about
Additional Context