Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logic to validate dbms set at changeset and stored procedure levels #3291

Merged
merged 4 commits into from Oct 11, 2022

Conversation

MalloD12
Copy link
Contributor

@MalloD12 MalloD12 commented Sep 20, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Implement validateDefinitions() methods to validate single or a list of dbms attribute values set for a given changeset or store procedure.

Fixes #1795

Things to be aware of

  • Validation logic basically relies on looking for a database a given definition (dbms).

Things to worry about

  • Nothing

Additional Context

  • Nothing

@github-actions
Copy link

github-actions bot commented Sep 20, 2022

Unit Test Results

  4 644 files  ±    0    4 644 suites  ±0   34m 34s ⏱️ - 1m 51s
  4 636 tests +  10    4 417 ✔️ +  10     219 💤 ±0  0 ±0 
54 804 runs  +120  49 780 ✔️ +120  5 024 💤 ±0  0 ±0 

Results for commit cefd673. ± Comparison against base commit 165c594.

♻️ This comment has been updated with latest results.

@MalloD12 MalloD12 assigned nvoxland and unassigned MalloD12 Sep 21, 2022
@nvoxland
Copy link
Contributor

Code review and test results:

Things to be aware of:

  • Changes make sense to me
  • Can see it catching mistyped dbms attributes in integration tests

Things to worry about:

  • Nothing

@nvoxland nvoxland removed their assignment Sep 29, 2022
@kevin-atx kevin-atx changed the title Implement logic to validate dmbs set at changeset and store procedure levels Implement logic to validate dbms set at changeset and store procedure levels Oct 3, 2022
@kevin-atx kevin-atx changed the title Implement logic to validate dbms set at changeset and store procedure levels Implement logic to validate dbms set at changeset and stored procedure levels Oct 3, 2022
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix allows Liquibase to validate that the DBMS values provided at the changeset level contain valid database platform shortnames. If a changeset has an unrecognized value in the DBMS attribute, by default, Liquibase will throw a validation error. The DBMS attribute can have one or many comma-separated database shortnames.

  • New tests added for one and many DBMS values.
  • New test added for createProcedure with DBMS values.
  • New test added for DBMS keywords "all" and "none."
  • No additional testing required.

APPROVED

@nvoxland nvoxland merged commit b5ce942 into master Oct 11, 2022
@nvoxland nvoxland deleted the fix-issue-1795 branch October 11, 2022 20:09
@kataggart kataggart added this to the 1NEXT milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"dbms" attribute doesn't validate input
5 participants