New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow renameColumn on newer SQLite versions #3264
Conversation
c9d65c5
to
4ac5a6e
Compare
4ac5a6e
to
40d4e0f
Compare
…e action to be processed on sqlite newer versions
ca88495
to
6e6533c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and test results:
Things to be aware of:
- Change is isolated to sqlite, and only for newer versions of sqlite
- Adds integration test for sqlite
- Functional tests are failing due to needed test changes not merged into master and is unrelated to this change
- Test-harness is failing on mssql due to datatbase not starting, but the sqlite one ran which should be all we need
Things to worry about:
- Nothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions of SQLite greater than 3.25 support renaming columns. This fix allows Liquibase to generate SQL for column renames for those newer versions. The logic for older versions of SQLite remains unchanged (does not allow for column renames).
- New integration test added to validate column rename.
- No additional testing required.
APPROVED
Impact
Description
Updated
supports()
method logic fromRenameColumnGenerator
class to returntrue
for SQLite database from version 3.25 or higher, or any other supported database.Fixes #2925
Things to be aware of
Things to worry about
Additional Context