Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed what sequence attributes are included in diff/generate changelog for Snowflake #3121

Merged
merged 2 commits into from Aug 2, 2022

Conversation

yodzhubeiskyi
Copy link
Contributor

@yodzhubeiskyi yodzhubeiskyi commented Jul 28, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Snowflake only supports operating 'startWith' and 'incrementBy' sequence attributes. The rests are set by default and are not allowed to be set or changed. In order for Liquibase to correctly work with those 'fixed' attributes we need to:

  • Throw a validation error when the 'fixed' attributes are present in changesets that are being applied to Snowflake
  • Include the values in JSON snapshots so the database is accurately and completely represented BUT
  • Exclude the 'fixed' attributes from any changesets generated by diffChangelog or generateChangelog so that we don't generate invalid changesets

@github-actions
Copy link

github-actions bot commented Jul 28, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   37m 38s ⏱️ + 2m 31s
  4 594 tests ±0    4 379 ✔️ ±0     215 💤 ±0  0 ±0 
54 300 runs  ±0  49 280 ✔️ ±0  5 020 💤 ±0  0 ±0 

Results for commit be18faa. ± Comparison against base commit fad9270.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 28, 2022
@yodzhubeiskyi yodzhubeiskyi changed the title DAT-11147 Fixed sequence generation for Snowflake Changed what sequence attributes are included in diff/generate changelog for Snowflake Aug 2, 2022
Copy link
Contributor

@KushnirykOleh KushnirykOleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one ask for a change, other than that looks good

@yodzhubeiskyi yodzhubeiskyi merged commit 205996a into master Aug 2, 2022
Conditioning++ automation moved this from To Do to Done Aug 2, 2022
@kristyldatical kristyldatical deleted the DAT-11147 branch August 2, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants