New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved handling of endDelimiter="/" #3118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inning of a line. Not in the middle and likely a division sign
…inning of a line. Not in the middle and likely a division sign
…inning of a line. Not in the middle and likely a division sign
suryaaki2
approved these changes
Jul 28, 2022
XDelphiGrl
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix improves handling of the Oracle end delimiter
/
by checking to see if the/
is at the beginning of a line and not within a statement. - New unit tests added.
- No additional testing required.
APPROVED
Thank you for the fix. I tested Liquibase 4.15 with my Oracle database setup and the problem has been resolved. |
This issue is seen again in 4.24 and 4.25. Is there something that broke this ? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
If people put endDelimiter="/", they really mean the oracle-style syntax of:
and we should treat that as such and not actually use "/" as a simple delimiter. Otherwise, something like:
splits in the wrong spot.
Fixes #2688
Things to be aware of
/
like this, this change just extends that to explicitly specifying endDelimiter="/"Things to worry about