Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when JAVA_HOME is set to invalid value (DAT-10545) #3074

Merged
merged 5 commits into from Jul 19, 2022

Conversation

StevenMassaro
Copy link
Contributor

@StevenMassaro StevenMassaro commented Jul 18, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Throw an error and fail to start Liquibase if the JAVA_HOME environment variable is set and the path it points to does not exist.

Things to be aware of

Things to worry about

If there is an edge case we didn't think about or test for, this will prevent Liquibase from starting in those scenarios.

Additional Context

@github-actions
Copy link

github-actions bot commented Jul 18, 2022

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   41m 13s ⏱️ + 4m 42s
  4 589 tests ±0    4 375 ✔️ ±0     214 💤 ±0  0 ±0 
54 240 runs  ±0  49 232 ✔️ ±0  5 008 💤 ±0  0 ±0 

Results for commit 6ec6897. ± Comparison against base commit 83faa21.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Both bash and batch only trigger the "does the file exist" check if JAVA_HOME is set so it won't break people not setting JAVA_HOME and relying on their PATH

@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 19, 2022
@StevenMassaro StevenMassaro changed the title properly handle multiple JAVA_HOME values separated by semicolons (DAT-10545) error when JAVA_HOME is set to invalid value (DAT-10545) Jul 19, 2022
@StevenMassaro StevenMassaro merged commit 1143689 into master Jul 19, 2022
Conditioning++ automation moved this from To Do to Done Jul 19, 2022
@StevenMassaro StevenMassaro deleted the DAT-10545 branch July 19, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants