Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Change Set" wording to "Changeset" #3042

Merged
merged 2 commits into from Jul 12, 2022
Merged

Updated "Change Set" wording to "Changeset" #3042

merged 2 commits into from Jul 12, 2022

Conversation

kataggart
Copy link
Contributor

@kataggart kataggart commented Jul 5, 2022

Changeset Consistency Naming conventions

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • [] Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Our style guide has "changeset" being the correct term vs. "change set". This updates all the usage of "change set" to match the standard.

Example Of Change

Run liquibase history against a database that has been updated by at least one changeset
Run liquibase status against a database that has at least one changeset needed to be updated.

Actual Behavior

The history command uses the name changesets
Database updated at 1/28/22, 4:53 PM. Applied 97 changeset(s) in 82.304s, DeploymentId: 3410389992

The status command calls uses the name change sets
2 change sets have not been applied to

Expected/Desired Behavior

Both commands use the same "changeset" terminology

Fixes #3041

Changeset Consistency Naming conventions #3041
@kataggart kataggart linked an issue Jul 5, 2022 that may be closed by this pull request
@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 5, 2022
@kataggart kataggart changed the title Update Liquibase.java Changeset Consistency Naming Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   29m 58s ⏱️ - 1m 23s
  4 578 tests ±0    4 360 ✔️ ±0     218 💤 ±0  0 ±0 
54 108 runs  ±0  49 096 ✔️ ±0  5 012 💤 ±0  0 ±0 

Results for commit 920cb4b. ± Comparison against base commit dd17e53.

♻️ This comment has been updated with latest results.

@nvoxland nvoxland changed the title Changeset Consistency Naming Updated "Change Set" wording to "Changeset" Jul 6, 2022
@nvoxland
Copy link
Contributor

nvoxland commented Jul 6, 2022

I did a search for all uses of "change set" and fixed them all

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This PR has no functional impact.
    • Standardizes changeset terminology in code comments and console messages.

APPROVED

Passing Functional Tests
Passing Test Harness Execution

@kataggart kataggart added this to the NEXT milestone Jul 12, 2022
@nvoxland nvoxland merged commit 958ec59 into master Jul 12, 2022
Conditioning++ automation moved this from To Do to Done Jul 12, 2022
@kataggart kataggart deleted the ktaggart-3041 branch August 12, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Changeset Consistency Naming conventions
3 participants