Fixed Formatted SQL "property" parsing

[nvoxland]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

A comment that has the word "property" in it anywhere like -- I don't know what this property does breaks formatted sql parsing with an Formatted SQL changelogs require known formats, such as '--property name=<property name> value=<property value>' and others to be recognized and run. error.

Fixes DAT-10720

Things to be aware of

• Only impacts how we parse for --property lines in formatted sql
• Existing tests look for correct forms, and they continue to pass

Things to worry about

• Nothing

[github-actions]

Unit Test Results

  4 560 files  ±  0    4 560 suites  ±0   32m 28s ⏱️ + 1m 20s
  4 540 tests +  1    4 322 ✔️ +  1     218 💤 ±0  0 ❌ ±0 
53 772 runs  +12  48 760 ✔️ +12  5 012 💤 ±0  0 ❌ ±0 

Results for commit eea140d. ± Comparison against base commit bd71f9f.

♻️ This comment has been updated with latest results.

[StevenMassaro]

Is it possible to add a test around this?

[XDelphiGrl]

• Fix addresses a bug where formatted SQL keywords that were not at the beginning of a line broke changelog parsing.
  • Keywords include property, changeset, rollback, precondition, comment, and ignoreLines, validCheckSum.
  • New unit tests added to FormattedSqlChanegLogParser for all of the keywords, in a variety of locations in a line.
• No additional testing required.

APPROVED

Passing Functional Tests
Passing Test Harness Execution

[kataggart]

Is it possible to add a test around this?

@nvoxland did you see this question on this one?

[nvoxland]

Yes, I added a tests for it @kataggart