Improve connection exception by including underlying driver exception trace #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is an unexpected exception while connecting to the database, liquibase should populate the "causedBy" exception so that it is possible to troubleshoot connection problems. Without this, users are shooting in the dark if the connection fails.
nvoxland
approved these changes
Jul 5, 2022
StevenMassaro
approved these changes
Jul 6, 2022
|
@StevenMassaro thanks for the quick review. Would you mind adding the tag |
nvoxland
added
the
SafeToBuild
|
Thanks for the reminder on the label. I added it |
|
Reproduced this PR on MySQL and looks like it works as excpected and showing the right complete stack trace Test Environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
When there is an unexpected exception while connecting to the database, liquibase should populate the "causedBy"
exception so that it is possible to troubleshoot connection problems. Without this, users are shooting
in the dark if the connection fails.
Things to worry about
Additional Context
I'm submitting this PR because of problems that my customers have using liquibase with
google cloud sql. Often the problems are related to configuration issues that prevent them
from connecting and are easily resolved. The configuration problems are explained in exception
messages thrown by the custom google cloud sql socket factory.
However, when my customers Liquibase, these messages are hidden. It would be helpful
to let them see the full stack trace.