Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional info in CLI's --version output #2942

Merged
merged 1 commit into from Jun 17, 2022

Conversation

nvoxland
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Currently --version output lists internal\lib\connector-api.jar: connector-api UNKNOWN because the connector-api.jar only defines a "specification version". This updates the message creation to use the specification version if nothing else is available as a version.

Also adds a "By ..." for the vendor information if it is present. It gets verbose for some like internal\lib\hsqldb.jar: HSQLDB 2.5.2 By The HSQL Development Group but others like internal\lib\ojdbc8.jar: JDBC 21.5.0.0.0 By Oracle Corporation were not descriptive enough without it.

Things to be aware of

  • Only impacts CLI --version call

Things to worry about

  • Nothing

…sion output

- Include "By ${Vendor}" in --version output if available
@nvoxland nvoxland requested a review from suryaaki2 June 14, 2022 18:08
@github-actions
Copy link

Unit Test Results

  4 548 files  ±0    4 548 suites  ±0   30m 36s ⏱️ +43s
  4 508 tests ±0    4 294 ✔️ +4     214 💤  - 4  0 ±0 
53 376 runs  ±0  48 368 ✔️ +4  5 008 💤  - 4  0 ±0 

Results for commit 1323630. ± Comparison against base commit 9985a44.

@FBurguer FBurguer self-assigned this Jun 17, 2022
@FBurguer
Copy link

All the shipped drivers that have vendor information have it now.

@nvoxland nvoxland merged commit e43bf18 into master Jun 17, 2022
Conditioning++ automation moved this from To Do to Done Jun 17, 2022
@nvoxland nvoxland deleted the more-library-info-in-version branch June 17, 2022 17:21
@kataggart kataggart added this to the NEXT milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants