hide CommandFailedException stacktrace when thrown to set exit code (DAT-9608) #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMassaro
requested review from
nvoxland,
wwillard7800,
abrackx and
suryaaki2
StevenMassaro
changed the title
suryaaki2
approved these changes
Jun 13, 2022
nvoxland
suggested changes
Jun 13, 2022
liquibase-core/src/main/java/liquibase/command/CommandFailedException.java
Outdated
Show resolved
Hide resolved
nvoxland
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Stacktraces will not be printed to the logs when a CommandFailedException is set to "hidden".
Things to be aware of
Things to worry about
isHiddenis perhaps not the best name we can come up with.Additional Context