Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added showBanner configuration to maven #2933

Merged
merged 1 commit into from Jun 10, 2022
Merged

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jun 9, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds a maven-native setting for the new liquibase.showBanner flag.

With the change, running mvn -Dliquibase.showBanner=false ... will hide the banner.

Things to be aware of

  • Only impacts maven
  • Applies to all maven commands
  • Can also be set with a <showBanner> configuration within the maven plugin.

Things to worry about

-Nothing

@nvoxland nvoxland added this to the NEXT milestone Jun 9, 2022
@nvoxland nvoxland requested a review from suryaaki2 June 9, 2022 15:54
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results

  4 548 files  ±  0    4 548 suites  ±0   29m 26s ⏱️ - 6m 49s
  4 506 tests  - 92    4 292 ✔️  - 92     214 💤 ±0  0 ±0 
53 352 runs  ±  0  48 344 ✔️ ±  0  5 008 💤 ±0  0 ±0 

Results for commit 9973aec. ± Comparison against base commit 6ba093d.

@kataggart kataggart added this to To Do in Conditioning++ via automation Jun 9, 2022
@FBurguer FBurguer self-assigned this Jun 10, 2022
@nvoxland nvoxland merged commit 5e44ef0 into master Jun 10, 2022
Conditioning++ automation moved this from To Do to Done Jun 10, 2022
@nvoxland nvoxland deleted the add-showbanner-to-maven branch June 10, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants