[DAT-10093] added schema escaping to getColumns call to jdbc metadata classes

[KushnirykOleh]

Environment

Liquibase Version: 4.11

Database Vendor & Version: all, fix needed for Snowflake

Operating System Type & Version: windows 10

Pull Request Type

https://datical.atlassian.net/browse/DAT-10093

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

JdbcDatabaseSnapshot doesn't escape percent and underscore characters in schema names for getColumns() calls like it does for getTables (and actually getViews). For Snowflake jdbc classes this cause to dropping schema name from requests completely what causes slow performance.

Steps To Reproduce

According to ticket description need to have Snowflake account with a number of schemas with number of tables and number of columns to clearly see Liquibase hangs for long time performing operations.

Actual Behavior

liquibase slow performance on Snowflake DB.

Expected/Desired Behavior

Performance increase.

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us in the Liquibase Forum.

[github-actions]

Unit Test Results

  4 548 files  ±0    4 548 suites  ±0   33m 4s ⏱️ + 3m 16s
  4 522 tests ±0    4 308 ✔️ ±0     214 💤 ±0  0 ❌ ±0 
53 544 runs  ±0  48 536 ✔️ ±0  5 008 💤 ±0  0 ❌ ±0 

Results for commit bc38268. ± Comparison against base commit bae65a4.

♻️ This comment has been updated with latest results.

[XDelphiGrl]

• Fix addresses a specific issue handling _ in Snowflake schema names.
• New unit tests added.
• No additional testing required.

APPROVED

Passing Functional Tests
Passing Functional Test Execution