Set max fractional timestamp digits to 12 for all DB2 editions (fix #2880)

[ctgnz]

Environment

Liquibase Version:
4.11.0
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Maven
Liquibase Extension(s) & Version:

Database Vendor & Version:
DB2 11
Operating System Type & Version:
Linux/Unix/Windows

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

• Describe the actual problematic behavior.
• Ensure private information is redacted.

Steps To Reproduce

1. In an existing DB2 database, create a table with a TIMESTAMP(12) column
2. Run generate-changelog

List the steps to reproduce the behavior.

• Please be precise and ensure private information is redacted
• Include things like
  • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
  • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

• Include console output if relevant
• Include log files if available.

The generate-changelog job fails with error saying that 12 digits is not supported by DB2:
[2022-05-30 16:07:50] SEVERE [liquibase.integration] Using a TIMESTAMP data type with a fractional precision of 12 is not supported on db2: A timestamp datatype with 12 fractional digits was requested, but DB2/LINUX X8664 only supports 9 digits.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

The generate-changelog job successfully creates the change log, because DB2 does support 12 digit precision in timestamps.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us in the Liquibase Forum.

[ctgnz]

Any progress on this?

[kataggart]

@ctgnz sorry we haven't yet been able to move this forward as we have had to focus on some higher priority work with the resources we have; I will talk with the team during standup tomorrow and see if we can put some time on it. Thanks!

[github-actions]

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   32m 30s ⏱️ - 1m 40s
  4 596 tests +  2    4 381 ✔️ +  2     215 💤 ±0  0 ❌ ±0 
54 324 runs  +24  49 304 ✔️ +24  5 020 💤 ±0  0 ❌ ±0 

Results for commit f2c8128. ± Comparison against base commit 28631d9.

♻️ This comment has been updated with latest results.

[nvoxland]

Code review and test results:

Things to be aware of:

• Only impacts db2 database types
• Changes make sense to me and don't impact existing tests

Things to worry about:

• Nothing

[XDelphiGrl]

• Fix removes a Liquibase limitation preventing DB2 timestamps greater than 9 from being snapshotted.
  • DB2 versions from 9.7 onward support a maximum of 12 digits in timestamps.
  • DB2 Timestamp Documentation
• Integration test added.
• No additional testing required.

APPROVED

Passing Functional Tests
Passing Test Harness Execution