Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAT-10294] added Snowflake as standalone module #2841

Merged
merged 5 commits into from Jun 7, 2022

Conversation

KushnirykOleh
Copy link
Contributor

Environment

Liquibase Version: 4.10

Liquibase Integration & Version: -

Liquibase Extension(s) & Version: snowflake ext latest main

Database Vendor & Version: Snowflake

Operating System Type & Version: Windows 10

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In order to add PRO support for Snowflake need to move it from extension to liquibase-core. Otherwise it creates unwanted dependency between PRO and Snowflake extensions.

Steps To Reproduce

List the steps to reproduce the behavior.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.
community changetypes runs, but no way to add support for PRO changetypes

Expected/Desired Behavior

have Snowflake as one DBs supported by liquibase-core directly, be able to enhance support level for this DB with PRO changetypes

Fast Track PR Acceptance Checklist:

Another PR #2835

@KushnirykOleh KushnirykOleh changed the title added Snowflake as standalone module [DAT-10294] added Snowflake as standalone module May 12, 2022
@github-actions
Copy link

github-actions bot commented May 12, 2022

Unit Test Results

  4 536 files  +  24    4 536 suites  +24   30m 8s ⏱️ - 2m 21s
  4 452 tests +  33    4 238 ✔️ +  37     214 💤  - 4  0 ±0 
52 704 runs  +396  47 696 ✔️ +400  5 008 💤  - 4  0 ±0 

Results for commit 22aa081. ± Comparison against base commit 4ab687b.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation May 12, 2022
@nvoxland nvoxland merged commit 2aebfa1 into master Jun 7, 2022
Conditioning++ automation moved this from To Do to Done Jun 7, 2022
@nvoxland nvoxland deleted the DAT-10294-snowflake-as-module branch June 7, 2022 16:06
@kataggart kataggart added ReleaseMajor Fix needs to be part of an x.y release, not an x.y.z patch release BreakingChange DocNeeded labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange daily_review DBSnowflake DocNeeded ReleaseMajor Fix needs to be part of an x.y release, not an x.y.z patch release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants