Change value modifier to make StandardLockService extendable for future extension #2785
Conversation
…xtensions that may need custom lock service like keyspace
…com/Cliftonz/liquibase into Cliftonz-standardLockService_More_Extendable
nvoxland
added
the
SafeToBuild
There was a problem hiding this comment.
The changes make sense. I held off a bit on it since we're planning some level of refactoring around StandardLockService at some point (including to make it more extensible) and making the internal fields protected will make us have to work harder to preserve them if/when we do the refactoring.
But, I'm not sure the timeline on that and so don't want to continue to block this on the off chance something changes then.
|
@nvoxland It looks like the CI thinks that this pr is not safe to build... |
nvoxland
added
SafeToBuild
|
@nvoxland What do I need to do to make Liquibase pro stable? or is this even needed for this to merge in? |
Hello, @Cliftonz! There is nothing you can do from your side to help with the stability of the Liquibase Pro build. I am kicking off the functional and test harness test suites manually; when those pass, I'll mark this as ready to merge. Thank you for the PR and for your patience! |
This pull request changes the modifiers of standard lock service to protected for the case where only certain parts of the lock service need to be rewritten.
An example is this pr in the Keyspace extension.
liquibase/liquibase-amazon-keyspaces#8