Fix for bug 2711: Error when calling a procedure with parameters on DB2Z

[michaelmatthiaskern]

Environment

Liquibase Version: 4.8.0

Liquibase Integration & Version: CLI

Liquibase Extension(s) & Version: -

Database Vendor & Version: DB2Z 12

Operating System Type & Version: Windows 10 Pro

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.) closes Error when calling a procedure with parameters on DB2Z #2711
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

We get an error when calling a procedure with parameters on DB2Z. Neither DB2LUW nor procedures without parameters are affected.

Steps To Reproduce

Create a procedure

CREATE PROCEDURE test(param integer)
BEGIN
END

and call the procedure

<changeSet id="9.36-un-35" author="mkern">
    <sql>CALL test(42)</sql>
</changeSet>

Actual Behavior

You will get the message

NO AUTHORIZED PROCEDURE NAMED TEST HAVING COMPATIBLE ARGUMENTS WAS FOUND. SQLCODE=-440, SQLSTATE=42884

Expected/Desired Behavior

The procedure should be called successfully.

Additional Context

This error is a DB2Z problem and also occurs also in other software, e.g. SQuirreL SQL Client, see https://sourceforge.net/p/squirrel-sql/bugs/1457/.

The issue seems to be due to an incomplete implementation of the JDBC driver or the DB2Z database. Instead of the Statement class the CallableStatement or the PreparedStatement class must be used, more details in the restrictions in https://www.ibm.com/docs/en/db2/11.5?topic=sql-calling-stored-procedures-in-jdbc-applications.

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Added Test Harness Test(s)
• Documentation Updated

Need Help?

Come chat with us in the Liquibase Forum.

[github-actions]

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   35m 12s ⏱️ + 1m 2s
  4 594 tests ±0    4 379 ✔️ ±0     215 💤 ±0  0 ❌ ±0 
54 300 runs  ±0  49 280 ✔️ ±0  5 020 💤 ±0  0 ❌ ±0 

Results for commit b644c8f. ± Comparison against base commit 28631d9.

♻️ This comment has been updated with latest results.

[nvoxland]

Code review and test results:

Things to be aware of:

• Change is isolated to db2/z
• Change makes sense to me
• I can't test it but assume the submitter knows it's needed

Things to worry about:

[XDelphiGrl]

@michaelmatthiaskern, hello! I've seen a couple of your PRs today and want to thank you for the very clear bug descriptions. Thanks!!!

[XDelphiGrl]

• Fix addresses a bug when DB2Z changesets execute CALL statments using parameterized procedures.
• Fix is isolated to DB2Z.
• No additional testing required.

APPROVED

Passing Functional Tests
Passing Test Harness Execution