Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest location (2nd position) in jar during re-version.sh #2666

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

nvoxland
Copy link
Contributor

Description

Fixes #2648 by repackaging the jar file. Includes a check in all jar files to ensure it worked correctly.

@github-actions
Copy link

Unit Test Results

  4 114 files    4 114 suites   33m 31s ⏱️
  4 339 tests   4 122 ✔️    217 💤 0
47 069 runs  42 444 ✔️ 4 625 💤 0

Results for commit b8546ef.

@kataggart kataggart added this to the NEXT milestone Mar 23, 2022
@nvoxland nvoxland merged commit 15b14eb into master Mar 23, 2022
@nvoxland nvoxland deleted the fix-manifest-location-in-jar branch March 23, 2022 18:01
@kataggart
Copy link
Contributor

@nvoxland just letting you know I took a look and from what I see the MANIFEST.MF is now in the second position

image

@kataggart kataggart changed the title Fix manifest location in jar during re-version.sh Fix manifest location (2nd position) in jar during re-version.sh Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Liquibase.jar does not have MANIFEST.MF as the 2nd entry in the archive
2 participants