-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor start-h2 logic #2597
Refactor start-h2 logic #2597
Conversation
…dStep and the old start-h2 standalone script is just a call to `liquibase init start-h2`
…dStep and the old start-h2 standalone script is just a call to `liquibase init start-h2`
Code review and test results: Things to be aware of
Things to worry about
|
@nvoxland Are you going to remove the |
Yes, there is a corresponding PR that removes that |
# Conflicts: # liquibase-core/src/main/resources/liquibase/examples/start-h2 # liquibase-core/src/main/resources/liquibase/examples/start-h2.bat # liquibase-dist/src/main/archive/examples/start-h2 # liquibase-dist/src/main/archive/examples/start-h2.bat
@nvoxland I've noticed that when I CTRL+C in the prompt where H2 is running, it takes a few seconds before the command is interrupted. Is that something that can be fixed, and is it fixed by your changes here? |
I added a commit to better handle that pause after "ctrl-c" I also updated the readme and getting_started pages |
This fix adds a new command
Test environment |
Description
Moved StartH2Main from being a stand-alone command to being integrated into the StartH2CommandStep.
The old examples/start-h2 scripts are still there, but are now calls to
liquibase init start-h2
rather than a separately boostrapped java call to StartH2Main.Fixes #2481