Fix quoting for MANIFEST.MF Import-Package #2573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing
"
into the search/replace logic that gets run at release to correctly version the MANIFEST.MF files.The Import-Package was replacing
version="..."
withversion="...
.I didn't see any other spots where we weren't missing characters in the replacement.
It's hard to see the result in automation, since that only happens when we start the release process, but running it locally with this change to make a "4.8.0" version, the MANIFEST.MF file looks like this:
Fixes #2361