Correctly set Bundle-Version in META-INF on release #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
approved these changes
Feb 8, 2022
XDelphiGrl
reviewed
Feb 22, 2022
| mkdir -p $workdir/test | ||
| unzip -q $outdir/*.jar -d $workdir/test | ||
|
|
||
| if grep -rl "0-SNAPSHOT" $workdir/test; then |
There was a problem hiding this comment.
Glad that we have this test, @nvoxland. Does this run as part of the release build, or is it something we need to run manually? If it is manual, let's add it to our internal release documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The in-development code always builds as version "0.0.0" and as part of the release process we replace the metadata that stores that placeholder version with the correct version. There are several places where that needs to be updated, including a Bundle-Version flag in META-INF/MANIFEST.MF, and that version was not updated correctly.
This fixes the logic for that, and also adds a check to the re-version.sh script to grep for 0-SNAPSHOT and 0.0.0.SNAPSHOT strings to catch any other problem spots that might get lost.
Fixes #2361