Don't repackage all org.apache.* classes. #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the artifact as internal dependencies.
suryaaki2
approved these changes
Jan 31, 2022
This was referenced Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we were renaming all org.apache.* packages, which broke any org.apache.* classes we reference but DON'T package, like Ant and Derby support.
Instead, just relocate the ones we shade into the artifact as internal dependencies.
Fixes #2391
Fixes #2388
Dev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
Ran test from #2391 after limiting change
Ensured there are no unshaded non-liquibase package names in the final jar file
┆Issue is synchronized with this Jira Bug by Unito