Log exceptions in CDILiquibase before rethrowing them #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
approved these changes
Feb 2, 2022
suryaaki2
approved these changes
Feb 3, 2022
|
@nvoxland will add unit test to validate fix. @XDelphiGrl will verify functional tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #2355 that fixes #2354
Rather than logging the exceptions only within changeset iterator, better catch all exceptions and log them withing CDILiquibase.
Dev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
Don't have a CDI environment to test in, but code is straightforward and issue author closed #2355 in favor of this fix.
┆Issue is synchronized with this Jira Bug by Unito