Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Github issue dealing with duplicate property keys #2351

Merged
merged 4 commits into from Feb 17, 2022

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Jan 10, 2022

Description

Fixes #2231


Dev Handoff Notes (Internal Use)

Links

Testing

Dev Verification

wwillard7800 developed it, nvoxland code reviewed

┆Issue is synchronized with this Jira Bug by Unito

Copy link

@JosephCen JosephCen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess maybe isDuplicate check should be added to line '127' as well.

@kataggart kataggart added this to To Do in Conditioning++ via automation Jan 11, 2022
@kataggart kataggart moved this from To Do to In Development in Conditioning++ Jan 11, 2022
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. The extra check got added on line 127

@nvoxland nvoxland moved this from In Development to Code Review in Conditioning++ Jan 13, 2022
@suryaaki2 suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Jan 21, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 21, 2022

➤ karen.a.taggart commented:

Wesley Willard removing you as assignee; please re-grab if it is supposed to be with you at this point. Thanks

@XDelphiGrl XDelphiGrl self-assigned this Feb 9, 2022
@@ -22,6 +24,28 @@ public void setParameterValue_doubleSet() {
assertEquals("re-setting a param should not overwrite the value (like how ant works)", "originalValue", changeLogParameters.getValue("doubleSet", null));
}

@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test! Thanks for adding it!

@nvoxland nvoxland merged commit e606925 into master Feb 17, 2022
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Feb 17, 2022
@nvoxland nvoxland deleted the fix_for_GH_2231 branch February 17, 2022 23:11
@nvoxland nvoxland added this to the v4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

The <property /> definition for column type does not work in version 4.6.1, which works well in 3.x.x
5 participants