New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Github issue dealing with duplicate property keys #2351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess maybe isDuplicate check should be added to line '127' as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. The extra check got added on line 127
➤ karen.a.taggart commented: Wesley Willard removing you as assignee; please re-grab if it is supposed to be with you at this point. Thanks |
@@ -22,6 +24,28 @@ public void setParameterValue_doubleSet() { | |||
assertEquals("re-setting a param should not overwrite the value (like how ant works)", "originalValue", changeLogParameters.getValue("doubleSet", null)); | |||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test! Thanks for adding it!
Description
Fixes #2231
Dev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
wwillard7800 developed it, nvoxland code reviewed
┆Issue is synchronized with this Jira Bug by Unito