Support adding computed=true columns with no type set

[nvoxland]

Description

Fixes #2283 by only requiring type when computed is false or not set.

---

Dev Handoff Notes (Internal Use)

Links

• Fixed Issue: It is no longer possible to create calculated columns on mssql #2283
• Test Results: https://github.com/liquibase/liquibase/pull/2340/checks

Testing

• Steps to Reproduce: It is no longer possible to create calculated columns on mssql #2283
• Guidance:
  • Impact: Changes validation and handling only for addColumn's type attribute
  • No XSD changes needed

Dev Verification

Tested the following changesets:

    <changeSet id="1" author="me">
        <createTable tableName="event">
            <column name="id" type="int"/>
            <column name="payload" type="varchar(10)"/>
        </createTable>
    </changeSet>
    <changeSet id="2" author="me">
        <addColumn tableName="event">
            <column name="payload_id AS JSON_VALUE(payload,'$.id')"
                    computed="true">
            </column>
        </addColumn>
    </changeSet>

    <changeSet id="4" author="nvoxland">
        <addColumn tableName="event">
            <column name="other_id" type="int"/>
        </addColumn>
    </changeSet>

including taking "type" off addColumn on id=4 to make sure that was still flagged as required when computed was not set

Manual testing
Setup
Use next changelog:

<changeSet id="1" author="Liquibase" labels="setup">
        	<createTable tableName="test_table1">
            		<column name="id" type="int"/>
            		<column name="value" type="varchar(10)"/>
        	</createTable>
    	</changeSet>

   	<changeSet id="2" author="Liquibase" labels="fix">
        	<addColumn tableName="test_table1">
            		<column name="value_id AS JSON_VALUE(value,'$.id')"
                    		computed="true">
            		</column>
        	</addColumn>
    	</changeSet>

	<changeSet id="3" author="Liquibase" labels="addError">
        	<addColumn tableName="test_table1">
            		<column name="third_id"/>
        	</addColumn>
    	</changeSet>
	
	<changeSet id="4" author="Liquibase" labels="test">
        	<createTable tableName="test_table2">
            		<column name="id" type="int"/>
            		<column name="value" type="varchar(10)"/>
			<column name="value_id AS JSON_VALUE(value,'$.id')"
                    		computed="true"/>
        	</createTable>
    	</changeSet>

	<changeSet id="5" author="Liquibase" labels="createError">
        	<createTable tableName="test_table3">
            		<column name="id" type="int"/>
            		<column name="value"/>
        	</createTable>
    	</changeSet>

Execute liquibase update --changelog-file changelog.xml --labels setup

Text cases
Verify update is successful for computed=true columns when there is no type attribute.

• liquibase update --changelog-file changelog.xml --labels fix,test
• update is successful
• computed column value_id is created for test_table1
• test_table2 is created with computed column value_id

Verify update throws an error when type attribute is missing for not computed column.

• liquibase update --changelog-file changelog.xml --labels addError
• columnType is required error is shown
• liquibase update --changelog-file changelog.xml --labels createError
• column 'type' is required for all columns error message is shown

┆Issue is synchronized with this Jira Bug by Unito

[yodzhubeiskyi]

Text results
Verify update is successful for computed=true columns when there is no type attribute. PASS

Running Changeset: changelog.xml::2::Liquibase
Running Changeset: changelog.xml::4::Liquibase
Liquibase command 'update' was executed successfully.

Verify update throws an error when type attribute is missing for not computed column. PASS

Unexpected error running Liquibase: Validation Failed:
     1 changes have validation failures
          columnType is required, changelog.xml::3::Liquibase

Unexpected error running Liquibase: Validation Failed:
     1 changes have validation failures
          column 'type' is required for all columns, changelog.xml::5::Liquibase

Liquibase version [Core: //support-add-computed-column/1463/67a603/2022-02-10 16:32+0000, Pro: master/591/f653ec/2022-02-09T18:09:13Z] #1463