Remove duplicate databasechangeloglock SQL when running update-sql against a new database

[nvoxland]

Description

Fixes #2309

Caused by the "are we locked?" loop we added to catch race conditions in clusters, since in "update sql" mode the table doesn't get created like it normally would.

When looking at the output SQL, I also saw that the lock table got unlocked and re-locked due to the HubService.register() logic thinking it can prompt when it really can't and so unnecessarily unlocking.

---

Dev Handoff Notes (Internal Use)

Links

• Fixed Issue: update-sql output bloated with excess DATABASECHANGELOGLOCK table CREATE, DELETE and INSERT statements. #2309
• Test Results: https://github.com/liquibase/liquibase/pull/2335/checks

Testing

• Steps to Reproduce: update-sql output bloated with excess DATABASECHANGELOGLOCK table CREATE, DELETE and INSERT statements. #2309
• Guidance:
  • Impact:
    • Only changes behavior when in "*-sql" mode
    • Updated the generic "can we prompt" logic to take into account whether the console supports input, not just what the passed configuration is.

Dev Verification

Ran update-sql against a new h2 database, and made sure the create and lock logic happens only once

Test Requirements (Liquibase Internal QA)

Setup

Make sure DATABASECHANGELOGLOCK table is not present in database.

Manual Tests

Verify update-sql outputs correct number of statements related to DATABASECHANGELOGLOCK table.

• liquibase update-sql --changelog-file lb2208-changelog.xml
• there is only one CREATE TABLE DATABASECHANGELOGLOCK statement
• there is only one INSERT INTO DATABASECHANGELOGLOCK statement
• there is only one DELETE FROM DATABASECHANGELOGLOCK statement
• there are only two UPDATE DATABASECHANGELOGLOCK statements (one before changesets and one after)

Execute update with setup label: liquibase update --changelog-file lb2208-changelog --labels setup

Verify update-sql outputs correct number of statements when DATABASECHANGELOGLOCK table already exists.

• liquibase update-sql --changelog-file lb2208-changelog --labels test
• there are no CREATE TABLE DATABASECHANGELOGLOCK statements
• there are no INSERT INTO DATABASECHANGELOGLOCK statements
• there are no DELETE FROM DATABASECHANGELOGLOCK statements
• there are only two UPDATE DATABASECHANGELOGLOCK statements (one before changesets and one after)

Automated Tests

No new functional tests required for this fix.

┆Issue is synchronized with this Jira Bug by Unito