New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional unicode letter points #2329
Conversation
@@ -31,7 +31,6 @@ class SimpleSqlGrammarTest extends Specification { | |||
"create table /* comment here */ test" | ["create", " ", "table", " ", "/* comment here */", " ", "test"] | |||
"insert 'a string'" | ["insert", " ", "'a string'"] | |||
"invalid ' sql" | ["invalid", " ", "'", " ", "sql"] | |||
|
|||
|
|||
"utf8-〠@chars works" | ["utf8", "-", "〠@chars", " ", "works"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this test.
The parse error reproduces during update-sql or update with insert statements of strings containing unicode characters into an ntext or nvarchar column. During initial testing, I used inserts with a value containing one problematic unicode character; this did not show the error because there was nothing to 'parse' with a single character. Special Thanks! Borja Serrano, your comment with a full SQL insert statement in CORE-3269 gave me what I needed to reproduce this bug. Thank you! Example XML Changelog with Insertshttps://app.zenhub.com/files/2019791/e41ea4e8-c4df-430c-9884-0ddef2af0b41/download
Test Environment |
Description
Comments in #1107 listed additional unicode points which cause problems with Japanese chars in sql
Dev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
Ensured existing parser-based tests pass. Did not add additional automated tests since we don't check for every possible char
┆Issue is synchronized with this Jira Bug by Unito