New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ClassLoaderResourceAccessor implement Closable #2308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a log message when close failed, but otherwise good. Thanks!
Just making it auto-closable doesn't help the existing code which should be calling the method. But, in looking through the code we have there is often too much of a disconnect between when the ClassLoaderResourceAccessor is opened/created and when it would need to be closed. So I'm good with just adding the method for now. I think that over the next few months as we do more refactoring of the code we can take better advantage of this new close method. And possibly consider adding it further up the ResourceAccessor chain |
@nvoxland please note this was approved as ready to merge |
Description
The ClassLoaderResourceAccessor opens resources but has no method for closing them. Add a close() method to clean it up as part of the AutoClosabable interface
Dev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
Reviewed code
┆Issue is synchronized with this Jira Bug by Unito