Mark liquibase-maven-plugin logging configuration as deprecated #2261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 4.0, we started ignoring the liquibase-maven-plugin configuration tag in favor of relying on the built-in maven logging system.
That means that liquibase now respects the
-q
,-X
and-e
flags and/or the ${maven.home}/conf/logging/simplelogger.properties file file.But, we just silently ignored the configuration users had.
This PR outputs an ERROR level log if the configuration is set letting users know it is being ignored.
New behavior
-q
,-X
and-e
flags or configure Maven logging properties file following these instructions: https://maven.apache.org/mavenlogging.html}} ERRORlevel messageDev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
Verified message when and only when the logging configuration is set.
Test Requirements (Liquibase Internal QA)
Manual Tests
Verify that log message is displayed when with global configuration.
<liquibase.logging>debug</liquibase.logging>
in your pom.xml file under propertiessection
Verify that log message is displayed when with liquibase
mavenplagin configuration.Verify that message is not displayed when configuration is not specified.
Automated Tests
No new functional tests required for this fix.
┆Issue is synchronized with this Jira Bug by Unito
┆fixVersions: Community 4.x