New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remarks support for column in MariaDB LB-1429 #2210
Conversation
@@ -142,7 +142,7 @@ public ValidationErrors validate(Database database) { | |||
String columnRemarks = StringUtil.trimToNull(column.getRemarks()); | |||
if (columnRemarks != null) { | |||
SetColumnRemarksStatement remarksStatement = new SetColumnRemarksStatement(catalogName, schemaName, tableName, column.getName(), columnRemarks, column.getType()); | |||
if (!(database instanceof MySQLDatabase) && SqlGeneratorFactory.getInstance().supports(remarksStatement, database)) { | |||
if (SqlGeneratorFactory.getInstance().supports(remarksStatement, database)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why this check about MySQL existed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot say for comment on commit doesn't really say much but I tested both on MariaDB and MySql and it works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. We'll want to make sure it's not failing on mysql after the change.
Environment
Liquibase Version:
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Liquibase Extension(s) & Version:
Database Vendor & Version:
Operating System Type & Version:
Pull Request Type
Description
A clear and concise description of the issue being addressed. Additional guidance here.
Steps To Reproduce
List the steps to reproduce the behavior.
Actual Behavior
A clear and concise description of what happens in the software before this pull request.
Expected/Desired Behavior
A clear and concise description of what happens in the software after this pull request.
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
Fast Track PR Acceptance Checklist:
Need Help?
Come chat with us on our discord channel