Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLite test fixes and automatic cleanup #2201

Merged
merged 3 commits into from
Nov 11, 2021
Merged

SQLite test fixes and automatic cleanup #2201

merged 3 commits into from
Nov 11, 2021

Conversation

StevenMassaro
Copy link
Contributor

This PR does two things:

  • Automatically delete SQLite database file from disk after JVM exits from running integration tests.
  • Comment out the changelog line which creates the foreign key which causes the test failures. I am unsure if this is the correct way to solve this problem. The other option for solving this problem is reverting this merge: Improve addColumn handling in SQLite #1970

@StevenMassaro StevenMassaro merged commit 618191f into master Nov 11, 2021
@StevenMassaro StevenMassaro deleted the sqlite-test-cleanup branch November 11, 2021 20:08
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryaaki2 suryaaki2 suryaaki2 approved these changes

@nvoxland nvoxland Awaiting requested review from nvoxland

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StevenMassaro @suryaaki2