[2054] fix OSGI support (manifest, class loading)

[jherkel]

see issue #2054

This patch fixes next things:

1. Java Service Loader issues -> I need to update MANIFEST file
2. loading of liquibase.build.properties file -> I need to load this file via bundle.getEntry
3. class loading problem for CustomChangeWrapper.java -> there is a problem that liquibase bundle cannot see classes from other bundles. This can be solved via dynamic import:* in MANIFEST.MF but it is not recommended way from OSGI point of view. So my solution is that there is a Activator class that is called when liquibase bundle is started or stopped. Under "start" method I registered BundleTrackerCustomizer that checked all bundles if they contain a special manifest entry "Liquibase-Custom-Change-Packages". When the entry exists bundle will be used for searching of CustomChange class.

Format for "Liquibase-Custom-Change-Packages" :

• <- all packages from bundle are allowed
  com.xyz.test,com.xyz.test2 <- only CustomChange classes from bundle that lie in these two packages (or packages under these packages) are allowed.

---

Dev Handoff Notes (Internal Use)

Links

• Fixed Issue: Liquibase 4.4.3 doesn't work under OSGI (Karaf 4.3.2) #2054
• Test Results: https://github.com/liquibase/liquibase/pull/2081/checks

Testing

• Steps to Reproduce: Liquibase 4.4.3 doesn't work under OSGI (Karaf 4.3.2) #2054
• Guidance:
  • Impact: Isolated to OSGi support

Dev Verification

Relying on people who know OSGi better to verify it improves it vs. what is in 4.6.2

┆Issue is synchronized with this Jira Bug by Unito

[molivasdat]

Hi @jherkel Thanks for creating this PR.

A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration) and/or Test Harness Tests
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[nvoxland]

I merged our master into your fork so that there are no conflicts and the build should pass and product artifacts.

I don't know OSGi well. So, @jherkel could you check that the snapshot artifact in the "checks" tab above still works for you on OSGi?

We've just finished some large build logic changes, so besides the merge conflict I want to make sure the change still works.

[driessamyn]

I merged our master into your fork so that there are no conflicts and the build should pass and product artifacts.

I don't know OSGi well. So, @jherkel could you check that the snapshot artifact in the "checks" tab above still works for you on OSGi?

We've just finished some large build logic changes, so besides the merge conflict I want to make sure the change still works.

FYI. I can confirm that this fork still works in the Felix OSGi framework after the latest merge.

[jherkel]

@nvoxland I will check it over the weekend.

[nvoxland]

Did you get a chance to verify the change, @jherkel ?

[jherkel]

Sorry, because of log2j issues I had to postponed this verification. Now I have little more time I will check it.

…

On Tue, Dec 21, 2021, 16:00 Nathan Voxland ***@***.***> wrote: Did you get a chance to verify the change, @jherkel <https://github.com/jherkel> ? — Reply to this email directly, view it on GitHub <#2081 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABK6DR5SUNHQ7YVN7J3DZALUSCI7PANCNFSM5DWPDWBQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[jherkel]

I've verified the latest merge with Apache Karaf 4.3.4 and it works

[nvoxland]

Great, thank you very much, @jherkel!