add postgres smallint to unmodifiable types

[jong82]

The smallint length was being added to the sql script generation, leading to incorrect syntax. Adding this to the list of unmodifiable types.

Built and tested locally.

Closes #1015

┆Issue is synchronized with this Jira Bug by Unito

[SteveDonie]

@nvoxland Please review. I have labeled it Risk:Medium just because I am not sure. If the risk is low, please change to that.

[ro-rah]

Hi @jong82

Thanks for your pull request!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest
changes, additional tests, or provide other feedback. The PR will be prioritized
according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[ro-rah]

@nvoxland, I kept this at Risk Medium, looks like we have room for that in the next sprint.

Looks like user identified when the issue may have started and then decided to add it unmodifiable types.

I can't say weather or not that or reverting the else if would be best, I defer to you.

[liquibot]

➤ Erzsebet Carmean commented:

Thanks for the contribution, @ jong82! I'm flagging this for internal discussion to help QA size a test effort.

-erz (@ XDelphiGrl)

CC: [~accountid:557058:c8f0b24d-f02f-431c-8842-fd9c929dfbf2]
CC: [~accountid:5d937e71f5d3c10d8bfd351d]

[liquibot]

➤ Erzsebet Carmean commented:

I'm going to need a little help understanding how to test this issue. Flagging for discussion.

-erz (@ XDelphiGrl)

CC: [~accountid:557058:c8f0b24d-f02f-431c-8842-fd9c929dfbf2]

[StevenMassaro]

Closing since this was already resolved, see #1046