Improved handling of endDelimiter="/"

[nvoxland]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

If people put endDelimiter="/", they really mean the oracle-style syntax of:

statement 1
/
statement2
/

and we should treat that as such and not actually use "/" as a simple delimiter. Otherwise, something like:

create table x id int default 2/4
/

splits in the wrong spot.

Fixes #2688

Things to be aware of

• Only impacts split logic when endDelimiter is /
• The default end delimiter already handles / like this, this change just extends that to explicitly specifying endDelimiter="/"

Things to worry about

• Nothing

[github-actions]

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   31m 11s ⏱️ - 2m 59s
  4 599 tests +  5    4 380 ✔️ +  1     219 💤 +4  0 ❌ ±0 
54 360 runs  +60  49 336 ✔️ +56  5 024 💤 +4  0 ❌ ±0 

Results for commit d9a0f32. ± Comparison against base commit 28631d9.

♻️ This comment has been updated with latest results.

[XDelphiGrl]

• Fix improves handling of the Oracle end delimiter / by checking to see if the / is at the beginning of a line and not within a statement.
• New unit tests added.
• No additional testing required.

APPROVED

Passing Functional Tests
Passing Test Harness Execution

[db-geek]

Thank you for the fix.

I tested Liquibase 4.15 with my Oracle database setup and the problem has been resolved.

[Sumitkrchaudhary]

This issue is seen again in 4.24 and 4.25. Is there something that broke this ?