Improved "include" fix performance: optimized normalizePath method

[lzxgyh]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Replaces on-the-fly regular expression usage with pre-compiled versions.

Fixes #2221
Fixes #1856

Things to be aware of

• Nothing

Things to worry about

• Nothing

Additional Context

Add any other context about the problem here.

[nvoxland]

Thanks @lzxgyh!
I updated the description to remove the boilerplate template with what was done.

I worry about the creation of the matcher static variables, though. If this gets used in a multithreaded way, I think those will cause problems. If you just create the matchers as local variables instead of resetting the static variables does it loose a lot of the performance gains? The original "compile" call should be what makes the most difference, right?

[lzxgyh]

Thanks @lzxgyh! I updated the description to remove the boilerplate template with what was done.

I worry about the creation of the matcher static variables, though. If this gets used in a multithreaded way, I think those will cause problems. If you just create the matchers as local variables instead of resetting the static variables does it loose a lot of the performance gains? The original "compile" call should be what makes the most difference, right?

Hi nvoxland

I think you are right, in the past, I always thought that liquibase was a single-threaded tool

[nvoxland]

Are you able to fix that up quick, @lzxgyh?

[lzxgyh]

Sure, I pushed a new commit to remove the matcher static variables , Please review @nvoxland

[github-actions]

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   39m 57s ⏱️ +19s
  4 589 tests ±0    4 371 ✔️  - 4     218 💤 +4  0 ❌ ±0 
54 240 runs  ±0  49 228 ✔️  - 4  5 012 💤 +4  0 ❌ ±0 

Results for commit 9194272. ± Comparison against base commit 1143689.

♻️ This comment has been updated with latest results.

[nvoxland]

Code review and test results:

Things to be aware of:

• Just moves implementation of where the regular expressions are managed from one spot to another, no functionality change
• I did not re-test the performance improvements, but I can see from the performance dumps that this what a large problem in the code and the PR will fix it as the contributor says it does

Things to worry about:

• Nothing

[XDelphiGrl]

Thank you, @lzxgyh - This is a nice improvement to code readability!

[XDelphiGrl]

• Fix improves performance of normalizePath.
• Fix improves readability of REGEX matching in DatabaseChangelog.java
• No additional testing necessary.

APPROVED

Passing Functional Tests
Passing Test Harness Execution