liquibase.sqlplus.path line in liquibase/examples/xml/liquibase.sqlplus.conf should be commented out

[malathit]

Closes #1416

Liquibase Internal QA Test Requirements

• Verify the liquibase.sqlplus.path is commented out in the Windows installer.
• Verify the liquibase.sqlplus.path is commented out in the Mac installer.

[codecov]

Codecov Report

Merging #1448 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1448      +/-   ##
============================================
+ Coverage     47.80%   47.96%   +0.16%     
- Complexity     7844     7870      +26     
============================================
  Files           792      793       +1     
  Lines         38516    38456      -60     
  Branches       6880     6901      +21     
============================================
+ Hits          18413    18446      +33     
+ Misses        17674    17566     -108     
- Partials       2429     2444      +15     

Impacted Files	Coverage Δ	Complexity Δ
...liquibase/integration/ant/AntResourceAccessor.java	75.00% <0.00%> (-25.00%)	3.00% <0.00%> (-2.00%)
.../integration/ant/type/ChangeLogParametersType.java	72.00% <0.00%> (-20.00%)	10.00% <0.00%> (-2.00%)
.../liquibase/integration/ant/DatabaseUpdateTask.java	40.00% <0.00%> (-12.00%)	2.00% <0.00%> (-1.00%)
...ava/liquibase/changelog/visitor/UpdateVisitor.java	69.69% <0.00%> (-6.07%)	6.00% <0.00%> (-2.00%)
...e/integration/ant/DiffDatabaseToChangeLogTask.java	55.88% <0.00%> (-4.40%)	11.00% <0.00%> (-2.00%)
...quibase/integration/ant/GenerateChangeLogTask.java	56.94% <0.00%> (-4.10%)	12.00% <0.00%> (-2.00%)
...uibase-core/src/main/java/liquibase/Liquibase.java	39.86% <0.00%> (-1.80%)	57.00% <0.00%> (-5.00%)
...-core/src/main/java/liquibase/util/ObjectUtil.java	36.31% <0.00%> (-1.68%)	34.00% <0.00%> (-2.00%)
...a/liquibase/integration/ant/type/DatabaseType.java	52.85% <0.00%> (-1.43%)	41.00% <0.00%> (-1.00%)
...ibase/parser/core/xml/LiquibaseEntityResolver.java	69.23% <0.00%> (-1.14%)	4.00% <0.00%> (ø%)
... and 39 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f71ff...6a09ef6. Read the comment docs.

[molivasdat]

This example needs to change to \\ for the Windows path
For instance
# liquibase.sqlplus.path=c:\\oracle\\product\\11.2.0\\client_1\\bin\\sqlplus.exe

[nvoxland]

Cherry picked to 4.3.x

[sync-by-unito]

➤ Erzsebet Carmean commented:

Liquibase 4.3.2-LB-1146-SNAPSHOT #2This fix is a change to a comments in a text file and was cherry-picked directly to 4.3.x. The build for LB-1146 brought in this change and I validated the installers from the LB-1146, #2 build.Verify the liquibase.sqlplus.path is commented out in the Windows installer. PASS
Verify the liquibase.sqlplus.path is commented out in the Mac installer. PASS

The new commented examples are:
{NOFORMAT}

1. The full path to the SQLPLUS executable.
2. Sample linux path
3. liquibase.sqlplus.path=/apps/app/12.2.0.1.0/oracle/product/12.2.0.1.0/client_1/bin/sqlplus
4. Sample windows path
5. liquibase.sqlplus.path=c:\oracle\product\11.2.0\client_1\bin\sqlplus.exe
   {NOFORMAT}

Everything here looks good. Thanks for the PR!