Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liquibase.sqlplus.path line in liquibase/examples/xml/liquibase.sqlplus.conf should be commented out #1416

Closed
szandany opened this issue Sep 18, 2020 · 2 comments · Fixed by #1448
Labels
hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs PRAssociated

Comments

@szandany
Copy link
Contributor

szandany commented Sep 18, 2020

Environment

Win, Unix
Liquibase Version:
3.10.2, 4.0.0
Liquibase Integration & Version: CLI

Description

In the liquibase install folder the file liquibase/examples/xml/liquibase.sqlplus.conf contains a the line: "liquibase.sqlplus.path=/apps/app/12.2.0.1.0/oracle/product/12.2.0.1.0/client_1/bin/sqlplus" should be commented out to avoid getting an error indicating that sqlplus cannot be found in path...

Steps To Reproduce

Run liquibase with a runWith changeSet from liquibase/examples/xml

Actual Behavior

Error will occur indicating that sqlplus path cannot be found.

Expected/Desired Behavior

The line "liquibase.sqlplus.path" should be commented out, and another line example should be provided for windows example with the "//" escape characters as a comment.

@ro-rah ro-rah added the hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs label Sep 28, 2020
@malathit
Copy link
Contributor

malathit commented Oct 2, 2020

Please check the PR #1448 and see if the changes are okay.

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 10, 2021

➤ Erzsebet Carmean commented:

I'm linking this ticket to a Community PR that address the issue. Testing will be conducted on that ticket instead of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs PRAssociated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants