Merge pull request #2549 from liquibase/mssql-no-ordered

MSSQL: Throw validation error if "ordered" is specified in createSequence/alterSequence
liquibase · Feb 17, 2022 · 6cdea2e · 6cdea2e
2 parents e72711a + 0e92b58
commit 6cdea2e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java
@@ -33,7 +33,7 @@ public ValidationErrors validate(AlterSequenceStatement alterSequenceStatement,
             validationErrors.checkDisallowedField("minValue", alterSequenceStatement.getMinValue(), database, H2Database.class);
         }
 
-        validationErrors.checkDisallowedField("ordered", alterSequenceStatement.getOrdered(), database, HsqlDatabase.class, DB2Database.class);
+        validationErrors.checkDisallowedField("ordered", alterSequenceStatement.getOrdered(), database, HsqlDatabase.class, DB2Database.class, MSSQLDatabase.class);
         validationErrors.checkDisallowedField("dataType", alterSequenceStatement.getDataType(), database, DB2Database.class, HsqlDatabase.class, OracleDatabase.class, MySQLDatabase.class, MSSQLDatabase.class);
         validationErrors.checkRequiredField("sequenceName", alterSequenceStatement.getSequenceName());
 

diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java
@@ -42,7 +42,7 @@ public ValidationErrors validate(CreateSequenceStatement statement, Database dat
             validationErrors.checkDisallowedField("AS", statement.getDataType(), database, PostgresDatabase.class);
         }
 
-        validationErrors.checkDisallowedField("ordered", statement.getOrdered(), database, HsqlDatabase.class, PostgresDatabase.class);
+        validationErrors.checkDisallowedField("ordered", statement.getOrdered(), database, HsqlDatabase.class, PostgresDatabase.class, MSSQLDatabase.class);
         validationErrors.checkDisallowedField("dataType", statement.getDataType(), database, DB2Database.class, HsqlDatabase.class, OracleDatabase.class, MySQLDatabase.class, MSSQLDatabase.class, CockroachDatabase.class);
 
         if (database instanceof H2Database && statement.getDataType() != null && !statement.getDataType().equalsIgnoreCase("bigint")) {