Fix #289: Add alternative execution for counting queries in lock service #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/liquibase/ext/cassandra/lockservice/LockServiceCassandra.java
Dismissed
Show dismissed
Hide dismissed
filipelautert
approved these changes
May 6, 2024
| @@ -62,19 +64,6 @@ public boolean acquireLock() throws LockException { | |||
| // another node was faster | |||
| return false; | |||
| } | |||
| if ((rowsUpdated == -1) && (database instanceof MSSQLDatabase)) { | |||
There was a problem hiding this comment.
Thanks for removing the trash here.
| } | ||
| try { | ||
| return executor.queryForInt(new RawSqlStatement(query)); | ||
| } catch (DatabaseException e) { |
As explained in the issue liquibase#289, the aggregate functions are not supported by AWS Keyspaces. This fix tries to execute counting queries and if it fails, the same query without the COUNT function is executed and the returned rows are counted programmatically. Also removes code specific to `MSSQLDatabase` in `LockServiceCassandra` obviously not related with Liquibase implementation for Cassandra.
filipelautert
force-pushed
the
fix/issue-289
branch
from
205bb2e
to
f7f6802
Compare
|
rberezen
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the issue #289, the aggregate functions are not supported by AWS Keyspaces.
This fix tries to execute counting queries and if it fails, the same query without the COUNT
function is executed and the returned rows are counted programmatically.
Also removes code specific to
MSSQLDatabaseinLockServiceCassandraobviously not relatedwith Liquibase implementation for Cassandra.