Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace selectattr filter with json_query filter #56

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

yontalcar
Copy link
Contributor

Some tests (like comparison) are missing in older Jinja. That makes
selectattr filter unusable on RHEL 7.

@pcahyna
Copy link
Member

pcahyna commented Oct 22, 2019

fixes #49 (hopefully)

tasks/main-blivet.yml Outdated Show resolved Hide resolved
@yontalcar
Copy link
Contributor Author

[citest bad]

Some tests (like comparison) are missing in older Jinja. That makes
selectattr filter unusable on RHEL 7.

Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
@pcahyna
Copy link
Member

pcahyna commented Jan 6, 2020

@dwlehman if there are no objections, I would like to merge it, because otherwise we have a problem with the soreage role on RHEL 7.

Copy link
Collaborator

@dwlehman dwlehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I have no experience with json_query.

Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants