New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode mrm@2 in the documentation #976
Conversation
Due to some changed in mrm@3 the entire installation task fails without easily searchable solution. This fixes the problem by hard locking mrm to @2 for as long as it's not solved properly.
Example of the issue:
|
Thanks @Palid! |
I believe this fixes #970 |
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 611 611
Branches 144 144
=========================================
Hits 611 611 Continue to review full report at Codecov.
|
Hmm I wonder if that’s the best way. @sapegin could you please take a look at why it’s not working anymore? |
@okonet I think that it's not a best way to do it, but it's better to have this temporary fix for documentation and figure out what's wrong there instead of having it broken without any simple solution. IMHO the best way to fix it now would be to merge this and revert it with the proper fix later. I can try investigating more on Wednesday too. |
I agree! Thanks for it. Let’s merge it. |
@okonet seems like a fix is waiting in the merge queue for a while now: sapegin/mrm#163 |
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Due to some changed in mrm@3 the entire installation task fails without easily searchable solution. This fixes the problem by hard locking mrm to @2 for as long as it's not solved properly.