Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better logging for js config errors #935

Merged
merged 3 commits into from Dec 4, 2020
Merged

better logging for js config errors #935

merged 3 commits into from Dec 4, 2020

Commits on Dec 4, 2020

  1. fix: Log compiler errors in js config files 

    Before this change javascript config files that had compilation errors or that threw their own errors wouldn't report the error, making debugging a mite more difficult than it should be: instead you'd get a useless "TypeError: Cannot read property 'errors' of undefined" message.  Now if the javascript config file tosses its cookies for whatever reason we can read what that reason was.
    @kf6kjg @iiroj
    kf6kjg authored and iiroj committed Dec 4, 2020
    Copy the full SHA
    a9f8e43 View commit details
    Browse the repository at this point in the history

  2. refactor: simplify check

    @iiroj
    iiroj committed Dec 4, 2020
    Copy the full SHA
    15c539e View commit details
    Browse the repository at this point in the history

  3. test: add test for unhandled error inside js function config

    @iiroj
    iiroj committed Dec 4, 2020
    Copy the full SHA
    4a5dc99 View commit details
    Browse the repository at this point in the history