Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Git directory is not resolved if GIT_WORK_TREE is set to relative path #887

Merged
merged 1 commit into from Jun 12, 2020
Merged

fix: Git directory is not resolved if GIT_WORK_TREE is set to relative path #887

merged 1 commit into from Jun 12, 2020

Commits on Jun 12, 2020

  1. fix: Git directory is not correctly resolved if GIT_WORK_TREE is set … 

    …to relative path

Resolving the git directory failed if the environment variable `GIT_WORK_TREE` is set to a relative path and lint-staged is run from a subdirectory of a Git repository (e.g. multi-package repos).

`GIT_WORK_TREE` can be used to set the worktree directory for a Git repo. `GIT_DIR` specifies only the `.git` directory path. `git rev-parse --show-toplevel` will return the Git worktree directory. If it is set to a relative path, it won't work when git commands are called from a subdirectory, as the relative path will fail to resolve correctly.

While `GIT_DIR` is unset in `resolveGitRepo.js`, `GIT_WORK_TREE` was not. Unsetting `GIT_WORK_TREE` in the same place fixes the issue.
    @alexrinass
    alexrinass committed Jun 12, 2020
    Copy the full SHA
    5e8bb4c View commit details
    Browse the repository at this point in the history